Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMD test optimization? #1724

Open
SoniEx2 opened this issue Feb 8, 2024 · 3 comments
Open

SIMD test optimization? #1724

SoniEx2 opened this issue Feb 8, 2024 · 3 comments

Comments

@SoniEx2
Copy link
Contributor

SoniEx2 commented Feb 8, 2024

A lot of the SIMD tests run the same floats through all of the lanes, instead of just assuming lanewise operations to be implemented in a lanewise way. Is there any particular reason to do it this way? You could probably cut down the size of the tests by a factor of 2 or 4 if you just assumed all the lanes behave the same.

@rossberg
Copy link
Member

rossberg commented Feb 8, 2024

Isn't more detailed testing and more coverage always better?

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Feb 8, 2024

it would certainly be able to catch hardware bugs that only manifest with certain lanes.

but it also takes 4x longer?

@dtig
Copy link
Member

dtig commented Feb 9, 2024

Is speed a constraint for running tests? For operations that don't map to a single hardware instruction, or for engines that scalarize, testing all lanes could still be helpful in catching implementation bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants