-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple of repos are failing to update #73
Comments
This message usually means there is a merge conflict between a proposal repo and the spec repo. Usually, the way to resolve it is to ask the maintainers of the proposal repo to update it to the latest spec repo, and fix the merge conflicts that arise. |
Ok so I need to raise issues on proposal repos separately? |
Done. Meanwhile, is it worth pushing the partial update here (without tests from those repos) or better to wait until we have no conflicts? |
Thanks for filing those! If you're asking about submitting manual changes, then no, this repo should only contain the results of running the script, so that it's always easy to keep it up to date without worrying about losing manual edits. If the script ran to completion and said "done", then yes, it's ok to submit a PR with the changes it produced, even if there were proposal repos that were skipped due to conflicts. |
Yes, I'm asking about the script output. I'll submit in a sec. |
Done + submitted another PR for minor improvement to branch handling. |
Tests in the repo are currently out of date, e.g.
tail-call
has tests that use an old invalidget_local
instruction even though upstream repo has already fixed them tolocal.get
.I tried rerunning the script myself, but at least couple of repos fail to update with merge conflicts:
I'm not sure how these issues are usually resolved and at this point would ask someone more familiar with this repo to update the testsuite.
The text was updated successfully, but these errors were encountered: