Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: staticcheck fails #86

Closed
muhlemmer opened this issue Mar 20, 2020 · 0 comments · Fixed by #87
Closed

Testing: staticcheck fails #86

muhlemmer opened this issue Mar 20, 2020 · 0 comments · Fixed by #87

Comments

@muhlemmer
Copy link
Contributor

As noted in PR #85: On current master branch staticcheck fails:

$ staticcheck ./...
internal/wglinux/configure_linux_test.go:126:14: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:355:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:379:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:405:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:430:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:454:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:479:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)
internal/wglinux/configure_linux_test.go:504:12: netlink.Nested | 0 always equals netlink.Nested (SA4016)

$ staticcheck -version
staticcheck 2020.1.3

The solution seems simple, remove the bit-wise OR 0. I will work on a PR today fixing this.
muhlemmer added a commit to muhlemmer/wgctrl-go that referenced this issue Mar 20, 2020
@muhlemmer
Fix staticcheck warnings on bitwise OR 0
8737bc6 
Closes WireGuard#86
@muhlemmer muhlemmer mentioned this issue Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix staticcheck warnings on bitwise OR 0 muhlemmer/wgctrl-go
1 participant
@muhlemmer