Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpolation methods #178

Open
CangyuanLi opened this issue Jun 9, 2024 · 6 comments
Open

Add interpolation methods #178

CangyuanLi opened this issue Jun 9, 2024 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@CangyuanLi
Copy link
Collaborator

Reach feature parity with https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.interpolate.html

Working on this on the interpolation branch!

Since pandas uses the index as the x values, I think we should follow pola-rs/polars#16313.

@CangyuanLi CangyuanLi self-assigned this Jun 10, 2024
@abstractqqq
Copy link
Owner

How is this going? I finished the kdtree refactor and have some time on other stuff

@CangyuanLi
Copy link
Collaborator Author

hmm, I have written all the code at least, but haven't verified it is correct yet--not sure how much re-writing would get it to match scipy exactly. I haven't had the time to work on it for a while :(. I can commit what I have so far if you also want to work on it

@abstractqqq
Copy link
Owner

No worries. I will do a review once you are ready to merge.

@abstractqqq abstractqqq added the help wanted Extra attention is needed label Aug 19, 2024
@abstractqqq
Copy link
Owner

The branch is here.

Will work on it once I get more time.

@abstractqqq
Copy link
Owner

@CangyuanLi

Just want to make sure, the use case is that we fit the spline on the data points, which may have nulls. Then we fill the nulls using the spline that we fit. Correct?

@CangyuanLi
Copy link
Collaborator Author

Yes, exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants