actix-identity: Documentation of http_only() seems incorrect #211
Labels
A-identity
Project: actix-identity
C-documentation
Improvements or additions to documentation
good first issue
Good for newcomers
The comment on
CookieIdentityPolicy::http_only()
says "By default, theHttpOnly
attribute is omitted from issued cookies":actix-extras/actix-identity/src/cookie.rs
Line 259 in 5605178
However, it seems to me that the http_only
Option
defaults toNone
here innew()
:actix-extras/actix-identity/src/cookie.rs
Line 59 in 5605178
And if the option is
None
, then the flag is set to true here:actix-extras/actix-identity/src/cookie.rs
Line 85 in 5605178
And won't be changed here:
actix-extras/actix-identity/src/cookie.rs
Line 95 in 5605178
Unless I am overlooking something, it thus seems to me that the documentation is incorrect and should say that the HttpOnly attribute is set by default (or the behavior should be changed to match the documentation).
The text was updated successfully, but these errors were encountered: