Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board doesn't show up on circuitpython.org/downloads if searched for: e.g. feather tft should find feather s3 tft #1321

Closed
tyeth opened this issue Feb 8, 2024 · 2 comments · Fixed by #1322
Closed

board doesn't show up on circuitpython.org/downloads if searched for: e.g. feather tft should find feather s3 tft #1321

tyeth opened this issue Feb 8, 2024 · 2 comments · Fixed by #1322
Labels
bug Something isn't working

Comments

@tyeth
Copy link
Contributor

tyeth commented Feb 8, 2024

CircuitPython version

latest

Code/REPL

n/a

Behavior

search for tft, notice the 4 feathers amongst 5 results...
search for feather tft, notice only two reverse tft feathers.

I wanted the feather s3 tft at the time, but I'm sure the search issues relate to more boards.

Description

No response

Additional information

No response
@tyeth tyeth added the bug Something isn't working label Feb 8, 2024
@tyeth tyeth changed the title board doesn't show up if searched for: e.g. feather tft should find feather s3 tft board doesn't show up on circuitpython.org/downloads if searched for: e.g. feather tft should find feather s3 tft Feb 8, 2024
@dhalbert dhalbert transferred this issue from adafruit/circuitpython Feb 8, 2024
@makermelissa
Copy link
Collaborator

The reason that is happening is because if you type feather tft, it will search for the exact string in board names, manufacturers, titles, and keywords. The keywords section was added as a way to combat this problem, but it's not thorough. The only reason the reverse one was showing up was because it had some alternate spellings in the keywords sections.

There's a couple of possible fixes:

  1. Somebody would need to go through about 500 board files and add variations they think might work, which isn't very easy and likely to miss some.
  2. Revise the search to split up the terms so that it searches for "tft" or "feather" etc. Still not an easy endeavor, but probably easier than manually updating boards.

jepler added a commit to jepler/circuitpython-org that referenced this issue Feb 8, 2024
@jepler
Improve search
1a74019 
This turns the search function into more of a 'fuzzy search': The search
is expected to be a series of space-separated terms, but the terms can
appear in any order, can be just part of a word (e.g., "uefr" would match
"bluefruit") and with other terms between them.

So for instance after this change both "tft feather" or "feather tft"
will show the Feather ESP32-S3 TFT PSRAM (as well as 3 other feather
boards)

Closes adafruit#1321
@jepler jepler mentioned this issue Feb 8, 2024
Merged
@tyeth
Copy link
Contributor Author

tyeth commented Feb 8, 2024

Aha, that explains it! Thanks @makermelissa (and @jepler for smashing out a fix already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve search jepler/circuitpython-org
2 participants
@makermelissa @tyeth