Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect location of images when testing locally #1374

Closed
makermelissa opened this issue Mar 29, 2024 · 0 comments · Fixed by #1375 or #1378
Closed

Incorrect location of images when testing locally #1374

makermelissa opened this issue Mar 29, 2024 · 0 comments · Fixed by #1375 or #1378

Comments

@makermelissa
Copy link
Collaborator

It appears #1358 used an absolute path, which breaks the site for the purposes of local testing as it attempts to load non-existent images from circuitpython.org. Since the absolute path is only needed for RSS feeds, the URL should have been added to the feed page only.
@makermelissa makermelissa mentioned this issue Mar 29, 2024
Merged
jepler added a commit to jepler/circuitpython-org that referenced this issue Mar 30, 2024
@jepler
Generate absolute URLs automatically
1f54838 
This allows a `localhost:4000`-style URL to be generated for local
testing, but still gives an absolute URL, which enhances compatibility
with RSS readers. A comment is added explaining the reason for the
absolute URL.

Closes adafruit#1374
@jepler jepler mentioned this issue Mar 30, 2024
Merged
jepler added a commit to jepler/circuitpython-org that referenced this issue Mar 30, 2024
@jepler
Generate absolute URLs automatically
6d39e26 
This allows a `localhost:4000`-style URL to be generated for local
testing, but still gives an absolute URL, which enhances compatibility
with RSS readers. A comment is added explaining the reason for the
absolute URL.

Closes adafruit#1374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@makermelissa