Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification count reliability #275

Open
RobPruzan opened this issue Feb 26, 2025 · 0 comments
Open

Notification count reliability #275

RobPruzan opened this issue Feb 26, 2025 · 0 comments

Comments

@RobPruzan
Copy link
Collaborator

Because react scan reads from a store that eagerly tracks interactions and FPS drops, FPS drops that are considered severe can be read before it's confirmed the FPS drop is not tied to an interaction.

This is problematic since we have a higher threshold for interactions to be considered "severe" (500ms vs 200ms).

Interactions are always pushed to the store after FPS drops since we must await the performance api to get extra metadata about the interaction. This sometime causes an unintended flicker state of notification count.

The correct solution is detecting if an interaction is ongoing during the FPS drop, and ignore it while that interaction is not completed.

note: this is not easy because there are going to base cases interactions appear to start but never end because of the nature of how we track interactions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant