-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate using cache specific constructors #473
Comments
* See aio-libs#473: Deprecate using cache specific constructors * aio-libs#473 * `Cache` class was introduced as a proxy for instantiating the different backends. There should be only one way of doing things and `Cache` is the preferred way of doing that so will deprecate the others. * This is now applied to `cached._get_cache()`
This should probably also apply to creating the cache inside the decorator aiocache/aiocache/decorators.py Lines 207 to 208 in 02782c2
PR #568 was submitted. |
This is an open issue, so doesn't look like anybody has deprecated anything yet. |
I'm not sure how well this'll play with static typing, so I suspect we'll have to change this again as we introduce typing to the library. It seems slightly odd to me that we instantiate a wrapper class and pass the implementation class as an argument, rather than just using it directly. i.e. Why do |
Cache
class was introduced as a proxy for instantiating the different backends. There should be only one way of doing things andCache
is the preferred way of doing that so will deprecate the othersThe text was updated successfully, but these errors were encountered: