Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log errors caused by peer as errors in HTTP/2 #4041

Open
jrudolph opened this issue Feb 21, 2022 · 4 comments
Open

Don't log errors caused by peer as errors in HTTP/2 #4041

jrudolph opened this issue Feb 21, 2022 · 4 comments
Assignees
@johanandren
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding t:http2 Issues related to support HTTP2 t:server Issues related to the HTTP server

Comments

@jrudolph
Copy link
Contributor

In #30, we decided to log peer induced errors only as warnings or info. We should make sure the same is true for HTTP/2 to avoid spamming server logs with errors caused by broken clients / drive-by hacking attempts.
@jrudolph jrudolph added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:server Issues related to the HTTP server t:http2 Issues related to support HTTP2 labels Feb 21, 2022
@johanandren
Copy link
Member

When we fix this, would it be possible to also sneak in the peer ip in the warning/info message?

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jan 23, 2023
@patriknw
Copy link
Member

@johanandren Can you see if this can be fixed. These error logs might be a problem in Kalix.

@johanandren johanandren self-assigned this Jan 23, 2023
@johanandren
Copy link
Member

More or less related issues: #3939 and #1622

@johanandren johanandren mentioned this issue Jan 23, 2023
Merged
@johanandren
Copy link
Member

Tricky thing is that we don't know how to reproduce, pretty sure the error logging comes from Akka gRPC so did a downstream PR instead of changing anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanandren johanandren

Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding t:http2 Issues related to support HTTP2 t:server Issues related to the HTTP server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrudolph @patriknw @johanandren