-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for WebSocket Extensions #659
Comments
One example use case: web socket compression, current draft: https://tools.ietf.org/html/draft-ietf-hybi-permessage-compression-28 Nice overview here: https://www.igvita.com/2013/11/27/configuring-and-optimizing-websocket-compression/ Implementing this either requires a way to register such an extension or to implement it internally in Akka HTTP. I think that even if we would implement permessage ourselves it would be nice if it was done through an extension API rather than directly in the blueprints etc. |
Note that the original ticket was closed because of lack of interest in it. |
Final version of the standard seems to be RFC 7692 One reason it is not completely trivial to implement is that JDK Deflate doesn't support setting window sizes to limit the amount of memory a receiver needs to keep between decompressing chunks. |
@jrudolph org.jcraft.jzlib supports setting the window size. |
+1 for compression |
Compression would be very good for my team's use cases too. |
It's been difficult to track exactly what the state of the art is in Web Sockets compression support, but it seems like most of the major browsers send headers related to compression: It seems like it should be possible for Akka HTTP to take this into account and enable compression when requested. |
The issue so far remains a low priority for us; if you'd like to give implementing this a shot, that would be very welcome though @acjay :-) Thanks in advance! |
+1 |
+1 |
akka-http akka/akka-http#659 okhttp square/okhttp#1733 async-http-client(via netty) AsyncHttpClient/async-http-client#1394
akka-http akka/akka-http#659 okhttp square/okhttp#1733 async-http-client(via netty) AsyncHttpClient/async-http-client#1394
+1, Is there any update on the server side compression? |
Compression is a use case for my team as well. We have a kind of request response pattern over the websocket and sometimes our responses are large around 1 to 4 MB. Now we put up a manual compression over it and we observed that the data size becomes 7% of what it was and the time between such a request and its response becomes 35% of what it was. Now, the problem with such a custom method is that debugging the websocket messages becomes a huge pain. I don't want to decompress every message for debugging some problem. For that reason we're not taking this to prod. I believe compression itself is a strong enough reason to support it natively. |
Websocket compression would be needed for my team as well! |
Continuation of akka/akka#18709
We currently do not support websocket extensions (i.e. registering "an extension" in the server, or requesting one in the client).
Currently we see no strong need to provide this functionality.
If you have a strong use case for it, please comment here
The text was updated successfully, but these errors were encountered: