Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: table supports the use of attributes #420

Closed
wants to merge 1 commit into from
Closed

feat: table supports the use of attributes #420

wants to merge 1 commit into from

Conversation

igauch
Copy link
Contributor

@igauch igauch commented Dec 8, 2022

close #419

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e35eaad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fengtianze
fengtianze reviewed Dec 8, 2022
View reviewed changes
src/table/table.component.ts Outdated
@@ -26,7 +26,7 @@ import {
} from './table-placeholder.directive';

@Component({
selector: 'aui-table',
selector: 'aui-table,[aui-table]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拆成一个新的组件作为后续重构的基础，selector用table[auiTable]，限定宿主必须是table元素，属性选择器都用camleCase。其他几个选择器也这样改

src/table/table.component.scss Outdated

.aui-table {
&__row,
&__header-row {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aui-table__row不是用在tr元素上的么，为什么还要改display

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成table-row以覆盖标签使用方式的flex布局

src/table/table.component.scss Outdated
}
}

tbody {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嵌套了table咋办，保持用bem class设样式

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些样式属于重置，不是设定自定义样式的

fengtianze
fengtianze reviewed Dec 28, 2022
View reviewed changes
src/table/new/table-cell.directive.ts

/** Cell template container that adds the right classes and role. */
@Directive({
selector: '[auiTableCell]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要限制宿主是td？

@fengtianze fengtianze closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengtianze fengtianze fengtianze left review comments

Assignees

@fengtianze fengtianze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table组件支持以属性的方式使用
2 participants
@igauch @fengtianze