Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DefaultLogRecord into IndexedLogRecord #389

Closed
1 of 2 tasks
wuchong opened this issue Feb 12, 2025 · 3 comments · Fixed by #394
Closed
1 of 2 tasks

Rename DefaultLogRecord into IndexedLogRecord #389

wuchong opened this issue Feb 12, 2025 · 3 comments · Fixed by #394
Assignees
Labels
Milestone

Comments

@wuchong
Copy link
Member

wuchong commented Feb 12, 2025

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

The DefaultLogRecord only supports for IndexedRow, and all the static methods in it are used for IndexedRow. So we should rename the class into IndexedLogRecord for better understanding.

Solution

No response

Anything else?

No response

Willingness to contribute

  • I'm willing to submit a PR!
@MehulBatra
Copy link
Contributor

I can take a jab at it @wuchong

@wuchong
Copy link
Member Author

wuchong commented Feb 12, 2025

Thank you @MehulBatra , assigned to you. Please reach out to me if you need any help.

@NazaninAnsarii
Copy link

Hey @wuchong and @MehulBatra,

Thanks for working on this issue! If you need any additional help or collaboration, I’d love to contribute as well. Just let me know! Good luck with the implementation! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants