Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename KvManager and LogManager into KvStore and LogStore #390

Open
2 tasks done
wuchong opened this issue Feb 12, 2025 · 0 comments
Open
2 tasks done

Rename KvManager and LogManager into KvStore and LogStore #390

wuchong opened this issue Feb 12, 2025 · 0 comments
Assignees
@wuchong
Labels
component=server

Comments

@wuchong
Copy link
Member

wuchong commented Feb 12, 2025

Search before asking

  • I searched in the issues and found nothing similar.

Description

There is an inconsistency between the documentation and the source code. The documentation refers to LogStore and KvStore in the architecture, whereas the source code uses the terms KvManager and LogManager.

To align with the documentation and avoid confusion for users exploring the codebase, consider renaming KvManager and LogManager to KvStore and LogStore, respectively. This renaming process may be complex, as we need to ensure that the new names don't conflict with the current code.

Willingness to contribute

  • I'm willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wuchong wuchong

Labels
component=server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wuchong