Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle spaces in arguments and executable path #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle spaces in arguments and executable path #11

wants to merge 2 commits into from

Conversation

kodemeister
Copy link

This PR fixes #10 and also supersedes #8. Unlike #8, it doesn't bring boost::algorithm dependency to the shim code, keeping it small and lightweight. If the changes look good to you, feel free to merge them and close #8.

@kodemeister kodemeister mentioned this pull request Aug 29, 2023
Open
@mnivet
Copy link
Contributor

mnivet commented Oct 11, 2023

In fact the shim code already has a dependency on boost::algorithm, because it use the resources.cpp code from shmake.
See here : https://github.com/aloneguid/win-shim/blob/master/shim/shim.vcxproj#L154

And that file depends on boost/algorithm/string.hpp
see here : https://github.com/aloneguid/win-shim/blob/master/shmake/resources.cpp#L5

But your solution is still better than the one I’ve come with, so I will close my PR, since i’ve now merge your solution into my personal branch.

@mnivet mnivet mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shim doesn't handle spaces in arguments and executable path
2 participants
@kodemeister @mnivet