-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search and filtering for endpoints #297
Comments
Thank you @NenadPantelic for bringing this to our attention and @devkapilbansal for confirming it! as you said on Zulip, these are the issues related: |
No prob, can I take this in that case? 😄 |
Sure @NenadPantelic |
Can I take up this issue in case of not completed |
I'm working on it, was a bit busy with some private things these days |
I was occupied with other issues these days, hope to the PR in next two days. |
@NenadPantelic any updates? |
Hey @vj-codes. Sorry, my timetable is full, I have a lot of things I'm working on at the moment. If @b-thebest or someone else is willing to, go ahead, the issue is yours. I'll ping you when I got some time if the issue is not solved at that point. |
Is your feature request related to a problem?
I was making a write-up about best REST practices and something essential came to my mind. A functionality so common that it's surprising we don't have it - search.
Describe the solution you'd like
I'd like features listed above to be supported in all endpoints (if applicable). It could be done using
BaseModel.filter()
method that Flask-SQLAlchemy provides.Search URL examples
/users?username=john
/users?location=us
/mentorship_relation/{request_id}/tasks?title=learn_react
Describe alternatives you've considered
We can do all this stuff on the client side and considering current scale of the project, it's not really a big deal. However, serious problems will arise if the number of users (or data in general) gets increased.
The text was updated successfully, but these errors were encountered: