Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and filtering for endpoints #297

Open
bartekpacia opened this issue Dec 19, 2019 · 8 comments
Open

Search and filtering for endpoints #297

bartekpacia opened this issue Dec 19, 2019 · 8 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days.

Comments

@bartekpacia
Copy link
Contributor

bartekpacia commented Dec 19, 2019

Is your feature request related to a problem?
I was making a write-up about best REST practices and something essential came to my mind. A functionality so common that it's surprising we don't have it - search.

Describe the solution you'd like
I'd like features listed above to be supported in all endpoints (if applicable). It could be done using BaseModel.filter() method that Flask-SQLAlchemy provides.

Search URL examples

/users?username=john
/users?location=us
/mentorship_relation/{request_id}/tasks?title=learn_react

Describe alternatives you've considered
We can do all this stuff on the client side and considering current scale of the project, it's not really a big deal. However, serious problems will arise if the number of users (or data in general) gets increased.

@isabelcosta isabelcosta added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Feb 23, 2021
@NenadPantelic
Copy link
Contributor

No prob, can I take this in that case? 😄

@devkapilbansal devkapilbansal removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 24, 2021
@devkapilbansal
Copy link
Member

Sure @NenadPantelic

@b-thebest
Copy link
Contributor

Can I take up this issue in case of not completed

@NenadPantelic
Copy link
Contributor

NenadPantelic commented Mar 2, 2021

I'm working on it, was a bit busy with some private things these days

@NenadPantelic
Copy link
Contributor

I was occupied with other issues these days, hope to the PR in next two days.

@vj-codes
Copy link
Member

@NenadPantelic any updates?
If there's no response from @NenadPantelic ,
@b-thebest are you still interested to work on this?

@NenadPantelic
Copy link
Contributor

Hey @vj-codes. Sorry, my timetable is full, I have a lot of things I'm working on at the moment. If @b-thebest or someone else is willing to, go ahead, the issue is yours. I'll ping you when I got some time if the issue is not solved at that point.

@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days.
Projects
None yet
Development

No branches or pull requests

6 participants