Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Review screen" to "Study screen" #341

Open
Danika-Dakika opened this issue Feb 5, 2025 · 5 comments
Open

Change "Review screen" to "Study screen" #341

Danika-Dakika opened this issue Feb 5, 2025 · 5 comments

Comments

@Danika-Dakika
Copy link
Collaborator

We've got no consistency between whether we call the screen-you-study-cards-on the "Study" or "Review" screen.

https://github.com/search?q=repo%3Aankitects%2Fanki-manual+%22study+screen%22&type=code
https://github.com/search?q=repo%3Aankitects%2Fanki-manual+%22review+screen%22&type=code

I'm going to advocate for "Study" screen --

  • We most frequently refer to the action as "study"-ing, including on the Study Now button on this screen, and the S shortcut.
  • The word "review" is already busy enough, being used for the card state and the daily limits.
@GithubAnon0000
Copy link
Contributor

Is this something that needs discussion or can I open a PR with your requested changes?

@brishtibheja
Copy link
Contributor

I like study screen too, but we call that screen "review" in the UI (don't know about desktop, AnkiDroid does it). There's also a screen called "study overview screen" so "study screen" sorta make sense.

I'd wait for dae's opinion on this.

@Danika-Dakika
Copy link
Collaborator Author

but we call that screen "review" in the UI (don't know about desktop, AnkiDroid does it)

Do we call it review in the UI? Where is that?
(I don't know where that is used in AnkiDroid either, but this is the manual for desktop, so it might not matter.)

@brishtibheja
Copy link
Contributor

In settings > controls there are options with the word "reviewer". In settings > appearance, there is a section caleed "reviewer". In gestures, we'd also add the word review to refer to that screen.

I think Anki manual using a different term puts slight pressure on AD devs to consider changing the names on their side.

@Danika-Dakika
Copy link
Collaborator Author

The Anki manual and the desktop app don't call it the "reviewer" anywhere, so I don't think that bears on the decision here, or that the decision here impacts AnkiDroid. I'm just looking for unanimity within desktop Anki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants