Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-83 Restore uniqueness constraint on logical date and make logical date nullable #46187

Closed
dstandish opened this issue Jan 28, 2025 · 4 comments
Closed

AIP-83 Restore uniqueness constraint on logical date and make logical date nullable #46187

dstandish opened this issue Jan 28, 2025 · 4 comments
Assignees
@vatsrahul1001
Labels
area:db-migrations PRs with DB migration
Milestone
Airflow 3.0.0

Comments

@dstandish
Copy link
Contributor

If there is a migration that drops the uniqueness constraint, don't add another migration just edit that one.
@dstandish dstandish converted this from a draft issue Jan 28, 2025
@dosubot dosubot bot added the area:db-migrations PRs with DB migration label Jan 28, 2025
@dstandish dstandish changed the title Restore uniqueness constraint on logical date and make logical date nullable AIP-83 Restore uniqueness constraint on logical date and make logical date nullable Jan 28, 2025
@vatsrahul1001 vatsrahul1001 self-assigned this Jan 29, 2025
@vatsrahul1001 vatsrahul1001 mentioned this issue Jan 29, 2025
Closed
This was referenced Jan 29, 2025
Closed
Merged
@phanikumv phanikumv moved this from Todo to In Progress in AIP-83 amendment Jan 30, 2025
@phanikumv phanikumv added this to the Airflow 3.0.0 milestone Jan 30, 2025
@vatsrahul1001 vatsrahul1001 mentioned this issue Feb 4, 2025
Merged
@raphaelauv
Copy link
Contributor

Hi , why do you restore uniqueness constraint on the logical_date ? thanks

@potiuk
Copy link
Member

potiuk commented Feb 6, 2025 •
edited
Loading

Hi , why do you restore uniqueness constraint on the logical_date ? thanks

That would take a lot to explain in a single comment but discussion here: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-83+amendment+to+support+classic+Airflow+authoring+style and https://cwiki.apache.org/confluence/display/AIRFLOW/Option+2+clarification+doc+WIP and related discussions linked in those docs.

It took us several weeks of discussions and I think three dev calls to come to this conclusion so I think the only way to understand "why" is to read all those discussions to get the full contetxt @raphaelauv

@raphaelauv
Copy link
Contributor

thanks for the context @potiuk

@Lee-W
Copy link
Member

Lee-W commented Feb 7, 2025

Close as #46295 is merged

@Lee-W Lee-W closed this as completed Feb 7, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in AIP-83 amendment Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vatsrahul1001 vatsrahul1001

Labels
area:db-migrations PRs with DB migration
Projects
AIP-83 amendment
Status: Done
Milestone
Airflow 3.0.0
6 participants
@potiuk @Lee-W @raphaelauv @dstandish @vatsrahul1001 @phanikumv