Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement regexp_is_match_utf8 and regexp_is_match_utf8_scalar for StringViewArray #6370

Open
Tracked by #6163
alamb opened this issue Sep 9, 2024 · 1 comment · May be fixed by #6376
Open
Tracked by #6163

implement regexp_is_match_utf8 and regexp_is_match_utf8_scalar for StringViewArray #6370

alamb opened this issue Sep 9, 2024 · 1 comment · May be fixed by #6376
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Sep 9, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We have implemented support for StringViewArray in arrow-rs (see #6163 and https://www.influxdata.com/blog/faster-queries-with-stringview-part-one-influxdb/ ) and to take full advantage of it, kernels that operate on strings (StringArray and LargeStringArray) need to be updated with specialized implementations that can

  1. Natively operate on StringViewArray without having to covert first to StringArray
  2. (Potentially) take advantage of the new string view layout

regexp_is_match_utf8 is one of these functions that does not have native StringViewArray support yet

Describe the solution you'd like

  1. Implement regexp_is_match_utf8 for StringViewArray
  2. Implement regexp_is_match_utf8_scalar for StringViewArray
  3. Tests for same

Describe alternatives you've considered
N/A

Additional context
@tlm365 implemented this downstream in datafusion -- apache/datafusion#12168. We can probably take a friendly look / move the implementation up to arrow-rs

@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels Sep 9, 2024
@tlm365
Copy link

tlm365 commented Sep 10, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
2 participants