Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Packaging] Documentation to build linux-packaging is outdated #45436

Closed
raulcd opened this issue Feb 5, 2025 · 3 comments
Closed

[Docs][Packaging] Documentation to build linux-packaging is outdated #45436

raulcd opened this issue Feb 5, 2025 · 3 comments

Comments

@raulcd
Copy link
Member

raulcd commented Feb 5, 2025

Describe the bug, including details regarding any error messages, version, and platform.

I am trying to fix some minor issues on the linux-packaging due to the CMake version upgrade PR and I wasn't able to find updated documentation on how to test locally. Testing via CI is slow and error prone. The documentation here should be updated:
https://github.com/apache/arrow/tree/main/dev/tasks/linux-packages#how-to-build-deb-packages

If I try the current docs it fails with:

$ rake version:update
apt-dists-merge is needed for apt:* tasks
cd apache-arrow
/usr/bin/ruby3.2 -S rake version:update
cd /home/raulcd/code/arrow/dev/tasks/linux-packages/../../..
cd -
cd apache-arrow-apt-source
/usr/bin/ruby3.2 -S rake version:update
cd /home/raulcd/code/arrow/dev/tasks/linux-packages/../../..
cd -
cd apache-arrow-release
/usr/bin/ruby3.2 -S rake version:update
cd /home/raulcd/code/arrow/dev/tasks/linux-packages/../../..
cd -
$ rake apt
apt-dists-merge is needed for apt:* tasks

It would be nice to add to the docs how to target specific linux packages to be build too by setting the environment variables.
Based on workflows on CI it seems we do the following:

      - name: Build
        run: |
          set -e
          pushd arrow/dev/tasks/linux-packages
          rake version:update ARROW_RELEASE_TIME="$(date --iso-8601=seconds)"
          rake docker:pull || :
          rake --trace apt:build BUILD_DIR=build
          popd
        env:
          APT_TARGETS: ubuntu-focal
          ARROW_VERSION: 20.0.0.dev66
          REPO: ${{ secrets.REPO }}
          YUM_TARGETS: ubuntu-focal

Component(s)

Packaging, Documentation

@kou
Copy link
Member

kou commented Feb 6, 2025

Ah, sorry. We need gem install apt-dists-merge.

@raulcd
Copy link
Member Author

raulcd commented Feb 6, 2025

but it is not required for APT_TARGETS=ubunut-focal rake --trace apt:build BUILD_DIR=build
I was able to run that locally without requiring apt-dists-merge

raulcd added a commit that referenced this issue Feb 10, 2025
)

### Rationale for this change

If we can build .deb/.rpm, we can debug .deb/.rpm build easily.

### What changes are included in this PR?

Update `dev/tasks/linux-packages/README.md`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #45436

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd added this to the 20.0.0 milestone Feb 10, 2025
@raulcd
Copy link
Member Author

raulcd commented Feb 10, 2025

Issue resolved by pull request 45481
#45481

@raulcd raulcd closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants