Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling subscribEventListener prior to notifySubscriber #15110

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Feb 7, 2025

What is the purpose of the change?

try to fix #15107

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.76%. Comparing base (0871406) to head (db1ebaf).

Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15110   +/-   ##
=========================================
  Coverage     60.75%   60.76%           
- Complexity    10865    10870    +5     
=========================================
  Files          1882     1882           
  Lines         86009    86016    +7     
  Branches      12887    12888    +1     
=========================================
+ Hits          52259    52268    +9     
+ Misses        28308    28307    -1     
+ Partials       5442     5441    -1     
Flag Coverage Δ
integration-tests 33.06% <100.00%> (+<0.01%) ⬆️
samples-tests 29.23% <100.00%> (+0.02%) ⬆️
unit-tests 58.90% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants