Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【问题】ConfigurationFactory 加载的打印信息有问题 #6956

Open
noear opened this issue Oct 28, 2024 · 2 comments
Open

【问题】ConfigurationFactory 加载的打印信息有问题 #6956

noear opened this issue Oct 28, 2024 · 2 comments

Comments

@noear
Copy link

noear commented Oct 28, 2024

"org.apache.seata.config.ConfigurationFactory" load 方法

extConfiguration = EnhancedServiceLoader.load(ExtConfigurationProvider.class).provide(configuration);
if (LOGGER.isInfoEnabled()) {
    LOGGER.info("load Configuration from :{}",
        extConfiguration == null ? configuration.getClass().getSimpleName() : "Spring Configuration");
}

当 java spi 加载到 ExtConfigurationProvider 时,会打印:"Spring Configuration"。。。

改为 extConfiguration.getClass().getSimpleName() 更合理。


比如,我在适配 seata-solon-plugin 时,java spi 配置的是 SolonConfigurationProvider,会被打印成了 "Spring Configuration"

@noear
Copy link
Author

noear commented Oct 28, 2024

适配两个(或以上)类似 spring 的框架。对解耦会有更好的帮助。

比如适配 solon,就发现一些潜藏的问题

@funky-eyes
Copy link
Contributor

这个问题可以提个pr来修改为中性含义的描述
This question can be changed to a description with neutral meaning by asking a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants