Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling common_prefix for score related files #28

Open
appukuttan-shailesh opened this issue Dec 15, 2017 · 3 comments
Open

Handling common_prefix for score related files #28

appukuttan-shailesh opened this issue Dec 15, 2017 · 3 comments

Comments

@appukuttan-shailesh
Copy link
Collaborator

@apdavison : This line gives problems when we have similarly named output files, e.g. /home/abcd/fig1.pdf and /home/abcd/fig2.pdf. The common prefix evaluates to /home/abcd/fig and the assertion fails.

We could change this to something like:
os.path.dirname(os.path.commonprefix(file_paths)) and then append a /.
This would make the assertion redundant. But I suppose you had certain errors in mind for keeping that assertion there?

@apdavison
Copy link
Owner

please go ahead and make the change. The assertion was a lazy way to mark this piece of code as needing further work ;-)

@appukuttan-shailesh
Copy link
Collaborator Author

appukuttan-shailesh commented Mar 21, 2018

Doing a temporary workaround to handle the above issue and cnr-ibf-pa/hbp-bsp-issues#245
See here: appukuttan-shailesh@9b44966

Temporary fix: all files in a single directory in Collab storage
If subdirs, then saved filename = subdir1_subdir2_....subdirN_filename

TODO improvements:

  1. Allow/verify multiple sub-directories of related data (the current fix will club all files into a single base directory)
  2. Validation framework app should identify sub-directories in results folder and iterate through these to identify all the individual files

@appukuttan-shailesh
Copy link
Collaborator Author

apdavison added a commit that referenced this issue Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants