-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling common_prefix for score related files #28
Comments
please go ahead and make the change. The assertion was a lazy way to mark this piece of code as needing further work ;-) |
Doing a temporary workaround to handle the above issue and cnr-ibf-pa/hbp-bsp-issues#245 Temporary fix: all files in a single directory in Collab storage TODO improvements:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@apdavison : This line gives problems when we have similarly named output files, e.g.
/home/abcd/fig1.pdf
and/home/abcd/fig2.pdf
. The common prefix evaluates to/home/abcd/fig
and the assertion fails.We could change this to something like:
os.path.dirname(os.path.commonprefix(file_paths))
and then append a/
.This would make the assertion redundant. But I suppose you had certain errors in mind for keeping that assertion there?
The text was updated successfully, but these errors were encountered: