Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing http2 server to ApolloServerPluginDrainHttpServer #7796

Open
jthoward64 opened this issue Dec 6, 2023 · 0 comments
Open

Allow passing http2 server to ApolloServerPluginDrainHttpServer #7796

jthoward64 opened this issue Dec 6, 2023 · 0 comments

Comments

@jthoward64
Copy link

Looking at the code for the drain plugin I don't think there's anything that isn't compatible with both and it would be nice if the TypeScript signature for ApolloServerPluginDrainHttpServer allowed passing in an http2.Server or an http.server (basically just make it an union).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jthoward64