Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayType formatting broken in Astro 5 #371

Closed
davidmytton opened this issue Jan 16, 2025 · 2 comments · Fixed by #382
Closed

DisplayType formatting broken in Astro 5 #371

davidmytton opened this issue Jan 16, 2025 · 2 comments · Fixed by #382
Assignees

Comments

@davidmytton
Copy link
Contributor

Upgrading to Astro 5 in #370 required me to workaround an error with our custom type formatter.

//let code = await format(types.join("\n"), { parser: "typescript" });

This needs fixing, although the output is already formatted correctly so maybe we don't need that line?

@blaine-arcjet
Copy link
Contributor

This needs fixing, although the output is already formatted correctly so maybe we don't need that line?

Disabling this made the Nosecone docs extremely frustrating to read because the string literals don't get wrapped.

I don't see the runtime failure on main. When did it happen? In the dev server or only in production?

@davidmytton
Copy link
Contributor Author

It was in dev at runtime when loading one of the pages that uses the code e.g. the Nosecone reference. However, I can't reproduce it now.

@davidmytton davidmytton closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants