Fix unicode / option handling blockers #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* produce debug-level log with exception detail if printing fails * exclude options whose values are the string 'None' * ensure ownerId is passed to CUPS as escaped-unicode string.
removed dubious string handling in error message
reduced line length (to pass armooo/cloudprint CI flake8 test)
last attempt at manual flake8 compliance
seems a bit silly not to add the install section.
small typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137 for me - fix contained within 761a30a
This PR also contains 03d2c3f - an example systemd
servicefile (but I appreciate this is an enhancement and separate PR; I will split these on request).