Spaces in configure-options seem to be un-escapable. #231
Comments
jackjansen
added a commit
to cwi-dis/cwipc
that referenced
this issue
Apr 21, 2022
jackjansen
added a commit
to cwi-dis/cwipc
that referenced
this issue
May 1, 2022
* Only ignore directories starting with build, not all files * workflow pulled over from cwipc_util branch issue32-github-actions * Changes to update to the new situation with the umbrella repo. Let's see what happens. * Checkout submodules * For now disable OSX and Windows builds * Playing with how to install dependent packages * Trying to get actions to work again * More installations * Fixed indentation * Sigh, pcl is no longer available with choco. Attempt to use vcpkg * Fixed where to use sudo and where not * Adding vcpkg as a submodule, which seems to be preferred usage * Other way of using vcpkg. Output test failures (if there are failures) * Attempting to find out why k4aoffline tests fails on Linux * install boost with choco on windows (hoping this forestalls building from source with vcpkg) * Ensure lfs content is checked out, also in submodules * Attempting install * Retry github action build * Temporary do Windows builds only * Attempting to use a vcpkg.json file, to allow caching of built dependencies in the CI/CD on windows * Temporarily remove gitlab ci/cd. Don't merge. * Fixed syntax error * Don't install boost with choco on windows * For debugging, upload vcpkg directory as arifact * Pack vcpkg using tar * vcpkg too big. Keep du listing only. * vcpkg too big. Keep du listing only. * vcpkg isnt working. Try all-in-one pcl installer * Fixed curl command * More hacking to try and install pcl * More debugging * More debugging * More debugging * Trying aghain, now with powershell * Trying aghain, now with powershell * Trying aghain, now with powershell * Trying aghain, now with powershell * Trying aghain, now with powershell * Yet another attempt: download complete installed PCL directory from zipfile * Fixed yaml syntax error * Typo * Pass PCL_ROOT to cmake * Got rid of matrix, more hassle than it is worth. Use separate jobs. * Fixed indentation * Check why jpeg-turbo isn't found * Check why jpeg-turbo isn't found * Check why jpeg-turbo isn't found * More checking of build process * More checking of build process * Different way to save ctest log (and build folder on Windows) * Upload installed folder as artifact, another attempt at capturing build folder on failure * Temporarily remove gitlab ci/cd (while debugging github actions) * Install K4A sdks using installers and msi * Trying to find out what happened to k4a installs * Added opencv * Added opencv * Capture install logs * Capture install logs * Adding command from actions/runner-images#1704 in hope that will make installers run * python-opencv doesn't exist * Use Start-Process -Wait to run installers * Use Start-Process -Wait to run installers * Use Start-Process -Wait to run installers * Use Start-Process -Wait to run installers * Check that we have enough disk space * More fiddling * Giving up on getting installers to run under github actions. Prepared zipfiles for k4a and k4abt and download and unpack those. * Allow specifying K4A_ROOT and K4ABT_ROOT on windows * Fixing cmake options. * Sigh, put cmake in trace mode * We used to add BUILD_TYPE to bin/lib folder paths. Disabled, to get rid of double BUILD_TYPE on github actions (possibly due to newer cmake version) * Check what environment variables are available * Get rid of workaround to add CMAKE_BUILD_TYPE to output directories. * We should setup the output directories * Added GITHUB_REF_NAME to archive filenames * Cater for BUILD_TYPE in windows PATH * Get rid of vcpkg * Install libjpeg-turbo from installer, not through choco (which has a grossly outdated version) * Reference environment variables with env. * Removed quotes * Merged master into inssue16-cmake * Merged master into inssue16-cmake * Re-adding gitlab-ci.yml * Use install script to install third party packages * Removed CMAKE_BUILD_TYPE from paths for runtime/library/archive output directories. See what this does for Windows builds on gitlab and github. * Run the windows install script, see if this fixes at least the Python tests * Ensure cmake finds the correct Python (windows) * Python_FIND_STRATEGY also needed * Python_FIND_STRATEGY also needed * More debugging option tries * Try to fix python to use with Python3_EXECUTABLE * Convert python executable path to Windows form * Removed extraneous quotes * Move thridparty install dir out of source directory * Move thridparty install dir out of source directory * Fixed CMake ROOT variables to have the correct names * Fixed destination of 3rd party package unzip * Yet another case fix for a variable * Fixed stupid typo in kinect install path * Attempting to find out where 3rdparty packages are installed * Ah! DestinationPath should reference the parent of where to unzip an archive, not the destination folder. Let's see if that fixes things. * Now PCL can't be found. Trying PCL_DIR in stead of PCL_ROOT * Revert "Now PCL can't be found. Trying PCL_DIR in stead of PCL_ROOT" This reverts commit f3e29c1. * Typo in PCL pathname * Variables to define where packages are installed were wrong case. Fixed to k4a_ROOT and k4abt_ROOT. * Sigh. Adding quotes around cmake pathname arguments * Sigh. Adding quotes around cmake pathname arguments differently * No amount of quoting is going to work because of ashutoshvarma/action-cmake-build#231. * Wild idea: let's pass the parent dir of the PCL installation. * Install OpenCV * Direct OpenCV search to x64/vc15 * Sigh, another try. Install OpenCV to c:/opencv * Added cmake tracing to see if I can find opencv issue * Opencv self-extracting zip destination should also be parent folder * More debugging how opencv is installed * OpenCV was installed completely empty, only directory structure. See whether choco works better. * Fixed up some PATH additions * Check why osx/linux uploads are not working * Temporarily disable test on windows. Try and fix install dir. * Fixed environment variable reference * Run a script to find DLL loading problems * Use github.ref_name * Fixed path problems * Install dlltracer before tryig to use it * Do cmake calls from source directory (referring to build directory) * Use PCL 1.11.1 in stead of 1.12.1. It looks like the problem _may_ be that PCL 1.12 uses instructions that are unsupported on the CI/CD machines. * Re-enabled testsing on Windows. * Install PCL with installer, waiting a random 120 seconds. See PointCloudLibrary/pcl#5216 for details. * Getting started on powershell script to ainstall all dependencies. * Moving towards running installers. * Fixing the first few installs. * Install most packages with original installer * Fixed some quoting * Disable Linux and MacOS for now * Playing with a script to return the git version information * Extract version numbers from version string * Don't print developer warnings * Fixed k4abt path * Make pip calls more quiet * Re-enabled linux and OSX builds * Use zip for windows aretefact * For reasons unknown we suddenly need to add the winsock libraries on Windows... * Getting started on creating a release * Fixed syntax error * Enable creation of releases, on tagged pushes * Generate version string from git describe during build. Export with cwipc_get_version() from C and Python APIs. Use when creating Python packages. Expose through cwipc_ scripts with --version option. * Generate version string from git describe during build. Export with cwipc_get_version() from C and Python APIs. Use when creating Python packages. Expose through cwipc_ scripts with --version option. * Ensure we have all tags (so version code works) * Ensure we have all tags (so version code works) * Getting rid of dead wood * Debugging git describe failure on gitlab ci/cd * Run pip installation for testing serially * Adding GIT_DEPTH: 999 because 50 may be too small * Isolate venv from system python, otherwise script entrypoints don't get installed for testing if the packages have been installed before running ctest * Apparently wheel is a separate module that needs to be installed * Sigh. See which python packages are installed * Tweaking linux build on gitlab, to see whether this fixes test failures * More tweaking linux build on gitlab, to see whether this fixes test failures * Work around open3d issue on Flauwte by not running those tests. * Updated documentation * Updated * Name the files to be uploaded for the release * Adding scripts directory to installation * Updated readme files * It seems action-gh-release doesn't upload files. Trying marvinpinto/action-automatic-releases * Going back to actions/create-release, even though it is unsupported. Because maybe it works, unlike the other actions... * Increase sleep time for installing pcl (sigh) * Forgot to add token to the creae-release step * download-artifact wants path to parent * Post release as draft and don't upload full release notes * Updated CHANGELOG * Submodules merged into master.
|
I have the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I need to have a
configure-optionwith a space in it. Specifically, I need to pass something-DXXXX_ROOT=C:/Program Files/XXXX. And I'm actually getting the pathname from an environment variable (with${{ env.XXXX_DIR }}).I have tried putting quotes in all sorts of places, but nothing works.
Then I went to the source of action-cmake-build, and saw that in
cmake_runner.tsline 73 you're doing a hard split on spaces:I get the impression that no amount of quoting or backslash-escaping or backslash-escaped-quotes that I can think of will get around this...
The text was updated successfully, but these errors were encountered: