Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with setting env vars #236

Open
antoniofagundes opened this issue Jan 30, 2023 · 2 comments · May be fixed by #237
Open

Issues with setting env vars #236

antoniofagundes opened this issue Jan 30, 2023 · 2 comments · May be fixed by #237

Comments

@antoniofagundes
Copy link

Hi,

Seems that using set-var has been deprecated by github.
Please look at the log here:
https://github.com/OrgPal/nf-interpreter/actions/runs/4045135464/jobs/6956201545

and the github blog here:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

@TheMaverickProgrammer
Copy link

Seconded. Really bums me out.

@maxxboehme
Copy link

Running into this issue as well. Need a similar fix that was done to the setup-ninja action for the 1.1 release. Running into issues when trying to update dependencies. I am not familiar with Node.js but I tried the following commands that I saw on StackOverflow trying to update the version in the package.json.

$ npm i -g npm-check-updates
$ ncu -u
Upgrading /home/mboehme/action-cmake-build/package.json
[====================] 18/18 100%

 @actions/core                ^1.2.6  →   ^1.10.1
 @actions/exec                ^1.0.4  →    ^1.1.1
 @actions/io                  ^1.0.2  →    ^1.1.3
 @types/jest                 ^24.9.1  →  ^29.5.12
 @types/node                ^12.19.6  →  ^20.14.9
 @typescript-eslint/parser   ^2.34.0  →   ^7.15.0
 eslint                      ^5.16.0  →    ^9.6.0
 eslint-plugin-github         ^2.0.0  →    ^5.0.1
 eslint-plugin-jest         ^22.21.0  →   ^28.6.0
 jest                        ^24.9.0  →   ^29.7.0
 jest-circus                 ^24.9.0  →   ^29.7.0
 js-yaml                     ^3.14.0  →    ^4.1.0
 prettier                    ^1.19.1  →    ^3.3.2
 ts-jest                     ^24.3.0  →   ^29.1.5
 typescript                   ^3.9.7  →    ^5.5.3
 yaml                        ^1.10.0  →    ^2.4.5

Run npm install to install new versions.
$ npm install
npm install
npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.6.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^8.56.0" from @typescript-eslint/[email protected]
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^7.15.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@maxxboehme maxxboehme linked a pull request Jul 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants