Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans on creating a full LSP #665

Closed
jhossbach opened this issue Nov 9, 2022 · 4 comments
Closed

Plans on creating a full LSP #665

jhossbach opened this issue Nov 9, 2022 · 4 comments
Labels
question Asking for support or clarification

Comments

@jhossbach
Copy link

Hey,
I was thinking about adding a plugin for linting the code using ruff for the python language server (https://github.com/python-lsp/python-lsp-server) but it seems like there already exists a language server using ruff, namely ruffd by @Seamooo.
I am wondering whether the plan for the ruffd language server is to become a full-blown LSP server according to the Microsoft specification or if the goal is to be integrated into existing LSP's?

@charliermarsh
Copy link
Member

My current thinking is that ruffd will evolve into a full-blown LSP server (it already is an LSP server following that spec, IIRC, though maybe it needs some more features).

The vscode-ruff plugin also implements Ruff into an LSP, though that's based on pygls as per the VS Code Python extension template, and there are plans to migrate that plugin to ruffd.

Does that make sense?

@charliermarsh charliermarsh added the question Asking for support or clarification label Nov 9, 2022
@jhossbach
Copy link
Author

Sounds great, I will ask the python-language-server maintainers in the meantime if they are interested in a plugin for linting purely.

@charliermarsh
Copy link
Member

Thanks! Cross-posting for posterity: python-lsp/python-lsp-server#299

@kuator
Copy link

kuator commented Nov 17, 2022

Will gladly ditch pyright for ruffd once it's mature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Asking for support or clarification
Projects
None yet
Development

No branches or pull requests

3 participants