Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Icon Sizes #178

Open
codeitco opened this issue Dec 3, 2016 · 8 comments
Open

Custom Icon Sizes #178

codeitco opened this issue Dec 3, 2016 · 8 comments

Comments

@codeitco
Copy link

codeitco commented Dec 3, 2016

It would be nice if there was a way to setup custom icon sizes without modifying the package source code.

I sync copies of the files I've changed to allow for more sizes but in doing so, if the core app is ever updated, I would lose all those changes and have to keep re-applying them.

@KTsarlz
Copy link

KTsarlz commented Dec 19, 2016

@codeitco How did you add custom font size? 16px is too small for me while 24 is too big. I would like yo add a custom font size but I don't know how?

@codeitco
Copy link
Author

Have a look at these files in the toolbar package:

\packages\tool-bar\lib\tool-bar.js,
\packages\tool-bar\styles\tool-bar.less,
\packages\tool-bar\lib\tool-bar-view.js,
\packages\tool-bar\package.json

If you search for either "16px" or "24px", you should find reference to the related code for the sizes. You can easily add in whatever custom sizes you want by appending to the code in the same consistent format with your new desired size(s). That's all I did.

Once you're done, restart atom, go back to toolbar settings, and you should see your new custom sizes in the drop down list.

Remember, if suda ever modifies the package, and it includes updates to those files listed above, your new sizes may disappear or you may break the installed package entirely, hence my request. :)

Hope that helps.

@KTsarlz
Copy link

KTsarlz commented Dec 21, 2016

@codeitco Thanks! Works for me. Tried it before but I wasn't able to achieve full functionality.

@codeitco
Copy link
Author

No problem. Glad you got it working! Now if only we could do something about all the freezing and lag atom has.

@Mgldvd
Copy link

Mgldvd commented May 18, 2017

Set icon size to 12px and
in your styles.less add this line:

.tool-bar.tool-bar-12px .tool-bar-btn:before {
    font-size: 15px;
}

@akhilcb
Copy link

akhilcb commented Aug 24, 2017

This is a much needed change. Is it possible to add a button on toolbar which can update size to smaller size when using laptop vs a bigger monitor? Probably some command exposed which can quickly be used to change size. Any suggestions?

@suda
Copy link
Collaborator

suda commented Feb 9, 2018

I think we could change the iconSize setting to be an regular input where anyone can enter the value they want (similarly to editor font size). Anyone feels like implementing it? :)

@Deefaze
Copy link

Deefaze commented Feb 10, 2018

In Desktop RAD IDE, Default sizes of button are 21px height (Delphi, VBS, Lazarus etc.).
Not standard : Smaller can be 18px (Listbox line height) and Bigger can be 27/28px (Panel height).

They sizes are really better than 16px, 24px and 32px, who are, NOT common buttons sizes BUT common ICONS sizes. Ha.

I think we can make "Responsive toolbar button". Atom is just Chrome ! Well, we can intercept media infos like screen size, landscape etc.
But, that hazardous, dev need frequently to switch windows or resize editor, this can be a cause of useless load or ui glitch. (tested width vw and % units ... that hurt).

Personnaly, i use Atom at home and work, home is a 24.4" screen @ 1920x1080, work is dbl wide screen 2560x1080. Home and Work filled with 24 x 21px fixed buttons and 8 spacers.

sans-titre-1

24 buttons is alreday very much. Need More ?
We will have to push the reflexion on Dropdown buttons or Buttons group (without inner margins)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants