[Bug]: using hostname to identify the host on macos allows DHCP servers to change content of "HOST" history search with default macos setup

[codyps]

What did you expect to happen?

Consistent hostname is assigned to commands executed on a given computer so that the HOST history search shows a growing list of history regardless of what network I'm connected to.

What happened?

Depending on what network I connect to (and what version of macos I'm using, as this changes the hostname sent to DHCP), I get different history from atuin.

For example, now that I'm running macos 15.0, my system sends a MacBookPro hostname to the DHCP server, and this DHCP server uses adds a suffix (.foo.example.com), causing the hostname (as returned via the hostname command, for example) to be MacBookPro.foo.example.com. This ends up in the history.db history table's hostname column.

If I connect to another network that has DHCP set to assign a different domain, that also is used by atuin, and the host search only shows the current understanding of the hostname (dependent on the network).

One can examine the "Local hostname" configured in the macos settings with scutil --get LocalHostName. On systems with macos prior to 15.0, this hostname is sent to the DHCP server, and in many cases means we would (prior to macos 15.0) get a hostname that looked somewhat right and often functioned correctly.

One can also use the command scutil --set HostName bar to set a fixed hostname, which the hostname command then returns. This is not exposed anywhere in the user interface for macos and is by default unset, meaning most users are likely to have their hostname change depending on dhcp settings today.

Atuin doctor output

Atuin Doctor
Checking for diagnostics


Please include the output below with any bug reports or issues

atuin:
  version: 18.2.0
  sync:
    cloud: true
    records: true
    auto_sync: true
    last_sync: 2024-09-20 3:57:49.643217 +00:00:00
shell:
  name: zsh
  default: zsh
  plugins:
  - atuin
system:
  os: Darwin
  arch: x86_64
  version: '10.16'
  disks:
  - name: Macintosh HD
    filesystem: apfs
  - name: Macintosh HD
    filesystem: apfs
  - name: dev
    filesystem: apfs

Code of Conduct

• I agree to follow this project's Code of Conduct