Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight reconstruction (guided laplacians): allow several instances. #132

Closed
pedrorrodriguez opened this issue Mar 27, 2023 · 6 comments
Closed
Assignees
Milestone

Comments

@pedrorrodriguez
Copy link
Collaborator

With the latest GL reconstruction speed has increased tremendously, allowing for a significant increase in iterations and thus, better results.

However, for certain images (sunsets, for example), often the diameter of the reconstruction does not suit the whole image: what may look great for when all three channels are clipped may not look good for larger areas where only one channel is clipped. Inpaint a flat color only mitigates the issue somewhat.

With previous methods, multiple instances didn't really make sense, but with GL, we could mask out several regions, and work them independently for best results.

TLDR. Allow for multiple instances of the module so different areas can be isolated and treated with different settings.

@aurelienpierre
Copy link
Collaborator

aurelienpierre commented Mar 27, 2023

Enabling instances and masking has the potential of breaking histories and compatibility

@pedrorrodriguez
Copy link
Collaborator Author

Perhaps my previous issue of increasing number of iterations for smaller diameters will take care of it. Let's see.

@pedrorrodriguez
Copy link
Collaborator Author

Btw, masking is already enabled, just not instances

@pedrorrodriguez
Copy link
Collaborator Author

What's the status on this? Should I close the issue?

@Jiyone
Copy link
Collaborator

Jiyone commented Jun 16, 2023

No don't close it, I believe this will be helpful too, that's an option I would like to have too.
The issue is that the reconstruction applies on all HL issues on the pictures instead of adapt for each case.
Maybe the solution would be to code something to adapt for each burned blobs individually without the need to multiply instances. 🤷🏻‍♂️

@aurelienpierre
Copy link
Collaborator

Done.

@aurelienpierre aurelienpierre added this to the 0.1 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants