Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone EQ: merge advanced and masking tabs #134

Closed
pedrorrodriguez opened this issue Mar 27, 2023 · 4 comments
Closed

Tone EQ: merge advanced and masking tabs #134

pedrorrodriguez opened this issue Mar 27, 2023 · 4 comments
Assignees
Milestone

Comments

@pedrorrodriguez
Copy link
Collaborator

pedrorrodriguez commented Mar 27, 2023

Using this module is cumbersome because functionality that should be together is separated into advanced and masking tabs. I suggest we merge them and get rid of the grey bar indicator in the masking tab.

tone eq-merged

Also, is there a use case for the simple view? If not, perhaps it can be removed as well.

EDIT: there is, since it's the only way to bind node adjustment to keyboard shortcuts.

@AlynxZhou
Copy link

I personally uses advanced tab everyday.

@pedrorrodriguez
Copy link
Collaborator Author

Also, perhaps the curve smoothing can be adjusted via scrollwheel on the graph (like denoise profiled and contrast equalizer) instead of via dedicated slider

@wilecoyote2015
Copy link

I strongly agree with this request.
Due to the different ranges of individual images, I have to switch between the tabs for almost every image.
Further consideration: Tuning of t maks postprocessing parameters would be significantly simpler if the historgram in the graph could be seen, which would be a nice side effect of merging the tabs

@aurelienpierre
Copy link
Collaborator

Done

@aurelienpierre aurelienpierre added this to the 0.1 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants