Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples use AVA 3 #2993

Open
jaapz opened this issue Mar 21, 2022 · 7 comments · May be fixed by #3335
Open

Examples use AVA 3 #2993

jaapz opened this issue Mar 21, 2022 · 7 comments · May be fixed by #3335

Comments

@jaapz
Copy link

jaapz commented Mar 21, 2022

In examples dir in the ava repo, TestInterface is still used, even though it's now called TestFn


@novemberborn: in fact all examples are using AVA 3 and need updating: https://github.com/avajs/ava/tree/a8981540100653d99d1fe9476737751eeae50b33/examples

@novemberborn
Copy link
Member

Is that this one? https://github.com/avajs/ava/tree/a8981540100653d99d1fe9476737751eeae50b33/examples/typescript-context

I think all those examples need updating to AVA 4. Will adjust this issue to reflect.

@novemberborn novemberborn changed the title TestInterface is still used in TypeScript examples Examples use AVA 3 Mar 21, 2022
@simplenotezy
Copy link

Thanks for sharing the TestFn rename from TestInterface. That was the main thing that had to be changed when upgrading from 3 to 4, and it wasn't referenced in the Changelog/releases section (https://github.com/avajs/ava/releases?q=TestFn&expanded=true)

Despite upgrade from 3 to 4 so far have been smooth, I have an issue related to upgrading from 3 to 4. Currently only one of my test folders run (the first one).

When I run:

cross-env NODE_ENV=test ava --verbose --timeout 1m

It will only run the first folder inside my ./test/ folder.

I added this issue here, as it might relate to upgrading from 3 to 4.

@simplenotezy
Copy link

Strange. I ran npm init ava (depsite it was only an upgrade), and then ran npm test again, and then it worked.

@novemberborn
Copy link
Member

AVA 5 is now available, though with minor changes. There was a PR for this but it has stalled: #3017

@simwai
Copy link

simwai commented Apr 20, 2024

Here is TestInterface used too:

@sculpt0r
Copy link
Contributor

Hi,
@novemberborn - what is the status here? We still needs to update the entire documentation - right?

It needs to be from scratch, or there is some ongoing PR?

@novemberborn
Copy link
Member

@sculpt0r still needs doing, yes.

I don't see any open PR around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@novemberborn @jaapz @simplenotezy @sculpt0r @simwai and others