Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the ESLint Suggestions API #281

Open
sindresorhus opened this issue Nov 23, 2019 · 2 comments
Open

Support the ESLint Suggestions API #281

sindresorhus opened this issue Nov 23, 2019 · 2 comments

Comments

@sindresorhus
Copy link
Member

There have been many cases where we could not provide auto-fixers because it was either not safe or there were multiple possible fixes. The Suggestions API enables us to provide multiple fixes that can be manually chosen by a user in an editor.

We should go through existing rules with no auto-fixers or with incomplete auto-fixers and make them support the Suggestions API.

@sindresorhus
Copy link
Member Author

I suggest (pun intended) that we drop auto-fixer for the no-only-test and no-skip-test and instead implement suggestions for them. Auto-fixers for those can be annoying (xojs/vscode-linter-xo#78) when you have "fix on save" in an editor.

@novemberborn Thoughts?

@novemberborn
Copy link
Member

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants