-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-ecs: aws-cdk-lib.aws_ecs.TaskDefinitionProps#inferenceAccelerators #33505
Labels
Comments
Reproducible using code below: import * as cdk from 'aws-cdk-lib';
import * as ec2 from 'aws-cdk-lib/aws-ec2';
import * as ecs from 'aws-cdk-lib/aws-ecs';
export class CdktestStackNew extends cdk.Stack {
constructor(scope: cdk.App, id: string, props?: cdk.StackProps) {
super(scope, id, props);
const vpc = ec2.Vpc.fromLookup(this, 'DefaultVpc', { isDefault: true });
// Create an ECS cluster
const cluster = new ecs.Cluster(this, 'Cluster', { vpc });
// Add capacity to it
cluster.addCapacity('DefaultAutoScalingGroupCapacity', {
instanceType: new ec2.InstanceType("t2.xlarge"),
desiredCapacity: 3,
});
const taskDefinition = new ecs.Ec2TaskDefinition(this, 'TaskDef');
taskDefinition.addContainer('DefaultContainer', {
image: ecs.ContainerImage.fromRegistry("amazon/amazon-ecs-sample"),
memoryLimitMiB: 512,
});
// Instantiate an Amazon ECS Service
const ecsService = new ecs.Ec2Service(this, 'Service', {
cluster,
taskDefinition,
minHealthyPercent: 100,
});
}
} Running
Unsure if simply conditional check in CDK L2 construct code triggers this deprecation warning and if there is a way to avoid it. |
This should not happen. While it's not really blocking customers, we need to check what's going on there. Bump to p2 and request for team's input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
I started to see multiple instances of the same warning (for every ECS Service created):
even though I am not even using that
inferenceAccelerators
property. I'm happy that the warning is there, but it should not be displayed if I am not using this property (without adding any flag).Regression Issue
Last Known Working CDK Version
No response
Expected Behavior
No warning should be displayed if property is not used.
Current Behavior
As above.
Reproduction Steps
As above.
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.178.1 (build ae342cb)
Framework Version
No response
Node.js Version
v22.14.0
OS
MacOS
Language
TypeScript
Language Version
└── [email protected]
Other information
No response
The text was updated successfully, but these errors were encountered: