Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Substitions are not supported for YAML #116

Open
karadjov opened this issue Feb 2, 2018 · 4 comments
Open

Template Substitions are not supported for YAML #116

karadjov opened this issue Feb 2, 2018 · 4 comments
Labels
feature-request A feature should be added or improved. module/cli-ext p2 This is a standard priority issue queued

Comments

@karadjov
Copy link

karadjov commented Feb 2, 2018

Currently Template Substitions are supported only for JSON.
https://github.com/aws/aws-lambda-dotnet/blob/911103991bb6c8b22216dc419f9cfb6986eaa764/Libraries/src/Amazon.Lambda.Tools/Utilities.cs#L450
This means we cannot use YAML if we want to use lambda deploy-serverless or lambda package-ci.

@normj
Copy link
Member

normj commented Feb 3, 2018

Yes, I haven't implemented YAML substitution yet. Its on my list of things to do, a pull request is also welcome :)

@klaytaybai klaytaybai transferred this issue from aws/aws-lambda-dotnet Apr 1, 2020
@NGL321 NGL321 added feature-request A feature should be added or improved. module/cli-ext labels Aug 7, 2020
@fabiob
Copy link

fabiob commented Sep 5, 2020

Any news on that? I can try to help with a PR.

@ashishdhingra
Copy link
Contributor

@fabiob Thanks for your reply. Please feel free to contribute with the PR which could be reviewed by development team.

@hauntingEcho
Copy link

hauntingEcho commented May 13, 2022

Our current deployment script to work around this is to:

  1. run dotnet lambda package-ci to handle the compilation/uploads
  2. run aws cloudformation package to handle AWS::Include of local resources
  3. actually deploy via Stacker (aws cloudformation deploy would probably work if you're deploying a single template)

edit: I may have misunderstood this issue as being about AWS::Include template substitutions rather than the --template-substitutions CLI argument

@ashishdhingra ashishdhingra added p2 This is a standard priority issue and removed A labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/cli-ext p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

7 participants