Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnasphotId from tags #7720

Open
timbgn opened this issue Feb 10, 2025 · 3 comments
Open

SnasphotId from tags #7720

timbgn opened this issue Feb 10, 2025 · 3 comments
Labels
feature New feature or request triage/accepted Indicates that the issue has been accepted as a valid issue

Comments

@timbgn
Copy link

timbgn commented Feb 10, 2025

Description

What problem are you trying to solve?
Populate snapshotId of Block Mapping from tags in AWS

How important is this feature to you?
We can work around this currently but feels like it would be nice to have karpenter read the tags of EBS snapshots and select the one matching provided tag values.

We are currently populating some large docker images and baseline pod images to an EBS snapshot and then hub-spoking out to organization accounts. I would like to be able to use our tekton pipeline to shunt the tag for latest snapshot around and have karpenter select that image.

This would open up various options to

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@timbgn timbgn added feature New feature or request needs-triage Issues that need to be triaged labels Feb 10, 2025
@jonathan-innis
Copy link
Contributor

So you basically want a snapshotSelectorTerm as well that you could reference inside of the blockDeviceMapping? What would you like to happen if this tag happened to select multiple snapshots?

@jonathan-innis jonathan-innis added triage/accepted Indicates that the issue has been accepted as a valid issue and removed needs-triage Issues that need to be triaged labels Feb 12, 2025
@timbgn
Copy link
Author

timbgn commented Feb 14, 2025

it is a good question. I could see both caveating the use to be having to select a unique snapshot or defaulting to the latest in CompletionTime of the returned snapshots would work. From my side of things I have been looking at moving a tag in the tekton pipeline we have that generates and copies the snapshot but am also considering having a timestamp of the pipeline run added so that it can be sorted to use the most recent.

@jonathan-innis
Copy link
Contributor

Can the same orchestration that you have in the Tekton pipeline be applied to updating the NodeClass? One high-level question I have is how is this different than directly updating the manifest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request triage/accepted Indicates that the issue has been accepted as a valid issue
Projects
None yet
Development

No branches or pull requests

2 participants