add_custom_command(TARGET) uses unsupported DEPENDS keyword

[kou]

Problem:

s2n-tls/CMakeLists.txt

Lines 446 to 452 in 3e57b05

	add_custom_command(
	TARGET ${PROJECT_NAME} POST_BUILD
	DEPENDS libcrypto.symbols
	COMMAND
	bash -c "${CMAKE_AR} -r lib/libs2n.a s2n_libcrypto/*.o"
	VERBATIM
	)

uses DEPENDS. But we can't use DEPENDS for add_custom_command(TARGET).

If we use DEPENDS for add_custom_command(TARGET), the following warning is reported:

The following keywords are not supported when using
add_custom_command(TARGET): DEPENDS.

-DS2N_INTERN_LIBCRYPTO=ON uses the add_custom_command(TARGET).

Solution:

We can remove the DEPENDS.

• Does this change what S2N sends over the wire? No.
• Does this change any public APIs? No.
• Which versions of TLS will this impact? TLS versions are not related.

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

• RFC links: Not related
• Related Issues: No relevant issue
• Will the Usage Guide or other documentation need to be updated? No
• Testing: We can check whether the warning isn't reported with -DS2N_INTERN_LIBCRYPTO=ON
  • Will this change trigger SAW changes? No.
  • Should this change be fuzz tested? No.

Out of scope:

Is there anything the solution will intentionally NOT address?

No.