Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3fs unit test broken before commit tagged by 2025.2.0 #559

Open
TRNWWZ opened this issue Feb 5, 2025 · 0 comments
Open

s3fs unit test broken before commit tagged by 2025.2.0 #559

TRNWWZ opened this issue Feb 5, 2025 · 0 comments

Comments

@TRNWWZ
Copy link
Contributor

TRNWWZ commented Feb 5, 2025

s3fs is one of our marquee dependency introduced in 2.3.0, its unit test keep failing due to error:

s3 = <s3fs.core.S3FileSystem object at 0x7fa76ea4f190>

    def test_info(s3):
        s3.touch(a)
        s3.touch(b)
        info = s3.info(a)
        linfo = s3.ls(a, detail=True)[0]
        assert abs(info.pop("LastModified") - linfo.pop("LastModified")).seconds < 1
        info.pop("VersionId")
        info.pop("ContentType")
        linfo.pop("Key")
        linfo.pop("Size")
>       assert info == linfo
E       assert {'ETag': '"d4...size': 0, ...} == {'ChecksumAlg.../test/a', ...}
E         
E         Omitting 5 identical items, use -vv to show
E         Right contains 1 more item:
E         {'ChecksumAlgorithm': ['CRC32']}
E         Use -v to get more diff

test_s3fs.py:271: AssertionError

The failure is due to a new change introduced since:
https://github.com/fsspec/s3fs/blame/2025.2.0/s3fs/tests/test_s3fs.py#L272

There is no actual functionality issue, but we cannot fix this unit test failure until a new major version bump to upgrade s3fs version.

We may also consider not follow semiver rule for s3fs, as its version represents timestamp only.

@TRNWWZ TRNWWZ mentioned this issue Feb 5, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant