Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay files - changes that were not applied #141

Open
ghost opened this issue Jan 20, 2018 · 1 comment
Open

Replay files - changes that were not applied #141

ghost opened this issue Jan 20, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 20, 2018

I've seen a replay file that has 'change' events that were not applied to the engine.
Looking at the manager code, it seems to send all requested changes to the viewer regardless of whether they were actioned successfully by the engine.

Can we add filtering so that only actions that were successfully parsed/actioned by the engine get added to the 'viewer changes'.

Extra info:
(Apply_turn function in battlecode-engine/src/controller/mod.rs line 1125) just makes a copy of the turn messages received.

Many thanks

@ygina
Copy link
Contributor

ygina commented Jan 23, 2018

@AppPackLtd We only push turn messages to turn.changes if the action is completed succesfully. (The self.world.apply(&delta)?; line immediately returns an error if unsuccessful.) Do you have a more specific example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant