Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript typings are wrong for onPicker* functions #414

Open
tbrent opened this issue Sep 14, 2020 · 0 comments
Open

Typescript typings are wrong for onPicker* functions #414

tbrent opened this issue Sep 14, 2020 · 0 comments

Comments

@tbrent
Copy link

tbrent commented Sep 14, 2020

This issue is about onPickerConfirm, onPickerCancel, and onPickerSelect.

It looks like the typings here are wrong. InPickerTest, there are examples where the callbacks receive the index of the selected value. However, this is not reflected in the typescript typings. Instead, they show:

onPickerConfirm?(item: any[]): void
...
onPickerCancel?(item: any[]): void
...
onPickerSelect?(item: any[]): void

I believe the correct typings should be of the form onPickerConfirm?(item: any[], index?: number): void.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant