Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend project with continent, ISO codes, and ccTLD data and new methods #41

Closed
sthiepaan opened this issue Oct 2, 2020 · 0 comments · Fixed by #42
Closed

Extend project with continent, ISO codes, and ccTLD data and new methods #41

sthiepaan opened this issue Oct 2, 2020 · 0 comments · Fixed by #42
Assignees

Comments

@sthiepaan
Copy link
Collaborator

sthiepaan commented Oct 2, 2020

As mentioned in #32 together with @bhatvikrant we decided to extend this package with:

For the project needs all new properties will be lowercase.

After adding all properties, each Country {Object} should contain:

{
  "country": "poland",
  "capital": "warsaw",
  "currency": "zloty",
  "native_language": ["polish"],
  "famous_for": "pierogi and potatoes",
  "phone_code": "+48",
  "flag": "https://flagpedia.net/data/flags/h80/pl.png",
  "drive_direction": "right",
  // NEW DATA
  "continent": "eu", // 1
  "iso": {  // 2
    "numeric": "616",
    "alpha_2": "pl",
    "alpha_3": "pol"
  },
  "tld": ".pl",  // 3
},

Additionally there will be new methods to use that data:

  • getCountriesByContinent(continentName)
  • getCountryDetailsByISO(isoType, isoValue)
  • getCountryDetailsByDomain(domainName)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant