Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback! #1

Open
codepathreview opened this issue Jul 17, 2018 · 0 comments
Open

Project Feedback! #1

codepathreview opened this issue Jul 17, 2018 · 0 comments

Comments

@codepathreview
Copy link

👍 Excellent Job. A few notes after checking out the code:

  • Properly reused the single base method in search activity to fetch results for both initial load and the pagination
  • Nice to see you added the search box to the ActionBar!
  • Properly used spinners (with populated values) or checkboxes to allow users to select filters
  • Good to see you used a filters object to represent the filters to apply to the query
  • Properly sent and received relevant filters using a bundle to pass data between activities
  • Nice work setting up shared preferences to persist the settings between activities
  • Nice work to see you implemented robust error handling, check if internet is available, handle error cases, network failures
  • Good to see you used the RecyclerView with the StaggeredGridLayoutManager to display improve the grid of image results
  • Good to see you replaced Picasso with Glide for more efficient image rendering
  • Nice job to see the user can scroll down to see more articles. The maximum number of articles is limited by the API search.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant