Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of DB Connection environment variable is inconsistent #678

Open
ontoneio opened this issue Oct 21, 2023 · 6 comments
Open
Labels
good first issue Good for newcomers

Comments

@ontoneio
Copy link

In the /.env.example file there is a variable named DATABASE_URL that is also present in the following files in this boilerplate:

  • app.json
  • README.md
  • deploy.template.yaml
  • env.ts

However in the documentation here: https://boxyhq.com/docs/jackson/deploy/env-variables#db_url

The environment variable is of a shortened case.
I don't mind making a pull request with these changes, but I was wondering if the long form of the variable is more favorable than the short one? In which case the change should be to the documentation on the site.

Super cool project everyone!
Thanks!

@devkiran
Copy link
Contributor

@ontoneio SAML Jackson uses DB_URL as the environment variable name. The DATABASE_URL is used by the @prisma/client package. Both are different packages hence the different variable names. Updating DB_URL to DATABASE_URL will effectively break SAML Jackson.

@deepakprabhakara
Copy link
Member

@devkiran DB_URL is not used by the embedded npm, we pass the URL to it.

@deepakprabhakara
Copy link
Member

Aah I see the confusion now, @ontoneio we could also support DB_URL here but don't think it's necessary

@ontoneio
Copy link
Author

ontoneio commented Oct 23, 2023

@deepakprabhakara Ok this all makes sense when explained here, but maybe it's worth clarifying somewhere in the docs? Perhaps in an INFO box on the environment variables page? Or maybe clarifying with this repo's README specifically? Whatever the case It's unclear which to use, or if we have to redundantly set both in order to use the boilerplate.

@deepakprabhakara
Copy link
Member

@ontoneio Agreed. We have to document all the env vars, README or a link in readme to another doc is a good place for that

@KazeroG
Copy link

KazeroG commented Feb 17, 2024

After analyzing all the env vars, this is the list for the best production env :

I use Vercel to deploy !


APP_URL=""
AUTH_PROVIDERS=""
CONFIRM_EMAIL=""
DATABASE_URL="postgresql://postgres:pasword-Gf@hostname:56736/db"
DISABLE_NON_BUSINESS_EMAIL_SIGNUP=""
FEATURE_TEAM_API_KEY=""
FEATURE_TEAM_AUDIT_LOG=""
FEATURE_TEAM_DELETION=""
FEATURE_TEAM_DSYNC=""
FEATURE_TEAM_PAYMENTS=""
FEATURE_TEAM_SSO=""
FEATURE_TEAM_WEBHOOK=""
GROUP_PREFIX="boxyhq-"
HIDE_LANDING_PAGE=""
MAX_LOGIN_ATTEMPTS="5"
NEXTAUTH_SECRET=""
NEXTAUTH_SESSION_STRATEGY=""
NEXTAUTH_URL=""
NEXT_PUBLIC_DARK_MODE=""
NEXT_PUBLIC_MIXPANEL_TOKEN="6"
NEXT_PUBLIC_PRIVACY_URL="/privacy"
NEXT_PUBLIC_SUPPORT_URL="/"
NEXT_PUBLIC_TERMS_URL="/terms"
NX_DAEMON=""
SMTP_FROM=""
SMTP_HOST=""
SMTP_PASSWORD=""
SMTP_PORT="587"
SMTP_USER=""
STRIPE_SECRET_KEY=""
STRIPE_WEBHOOK_SECRET=""
SVIX_API_KEY=""
SVIX_URL="https://api.eu.svix.com"
TURBO_REMOTE_ONLY=""
TURBO_RUN_SUMMARY=""
VERCEL="1"
VERCEL_ENV="development"
VERCEL_GIT_COMMIT_AUTHOR_LOGIN=""
VERCEL_GIT_COMMIT_AUTHOR_NAME=""
VERCEL_GIT_COMMIT_MESSAGE=""
VERCEL_GIT_COMMIT_REF=""
VERCEL_GIT_COMMIT_SHA=""
VERCEL_GIT_PREVIOUS_SHA=""
VERCEL_GIT_PROVIDER=""
VERCEL_GIT_PULL_REQUEST_ID=""
VERCEL_GIT_REPO_ID=""
VERCEL_GIT_REPO_OWNER=""
VERCEL_GIT_REPO_SLUG=""
VERCEL_URL=""
SENTRY_IGNORE_API_RESOLUTION_ERROR=1

@ukrocks007 ukrocks007 added the good first issue Good for newcomers label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants