Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Swift Concurrency / Sendable support for Braze #85

Open
3a4oT opened this issue Oct 26, 2023 · 3 comments
Open

[Feature]: Swift Concurrency / Sendable support for Braze #85

3a4oT opened this issue Oct 26, 2023 · 3 comments

Comments

@3a4oT
Copy link

3a4oT commented Oct 26, 2023

What problem are you facing?

Braze should conform to Sendable protocol and expose async functions for Swift consumers instead of Obj-C versions with completion handlers.

Braze.Notifications.categories - should be revamped since it's produces a warning if I add the following settings to the swift package:

            swiftSettings: [.unsafeFlags(["-Xfrontend",
                                          "-warn-concurrency",
                                          "-Xfrontend",
                                          "-enable-actor-data-race-checks"
                                         ])
                           ]

Please note that on Swift 6 there would be errors. Please prepare Braze API for Swift 6.

Workarounds

partially resolved by

@preconcurrency  import BrazeKit

Ideal Solution

No response

Other Information

No response

@3a4oT 3a4oT changed the title [Feature]: Sendable [Feature]: Sendable support for Braze Oct 26, 2023
@jerielng
Copy link
Collaborator

Hey @3a4oT, thanks for raising this. We've filed a ticket internally to dive into this to determine the best solution for supporting Sendable in Swift 6 and will keep you updated on a solution.

Thank you!

@hokstuff hokstuff changed the title [Feature]: Sendable support for Braze [Feature]: Swift Concurrency / Sendable support for Braze Jun 21, 2024
@twittemb
Copy link

+1

@nacho4d
Copy link

nacho4d commented Sep 7, 2024

In Xcode16, when Swift 6 is enabled then concurrency checks are done it causes compiler errors in a couple of places in braze sdk.
I hope braze developers prioritize on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants