Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fileDelimeter option? #97

Open
rwjblue opened this issue Dec 27, 2016 · 1 comment
Open

Add fileDelimeter option? #97

rwjblue opened this issue Dec 27, 2016 · 1 comment

Comments

@rwjblue
Copy link
Member

rwjblue commented Dec 27, 2016

While doing build work, I often open up dist/assets/vendor.js or dist/assets/vendor.css to inspect the contents (to confirm I didn't make any mistakes etc). It would be very convenient if we added delimiters surrounding each file that we concat.

Concretely, I am proposing:

  • Add support for a fileDelimeters option. A few special values could be used for substitution (e.g. {{FILE_PATH}} would be the path of the file being added).
    • Possible usage example: fileDelimeters: ['\n/* BEGIN {{FILE_PATH}} */', '\n/* END {{FILE_PATH}} */']
  • Default to "do nothing" (which means the built asset would be identical)
  • Update ember-cli to specify the fileDelimeters option in non-production builds.

Thoughts?

@stefanpenner
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants