Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

central issue for "default extensions" #166

Open
ljharb opened this issue Jun 16, 2018 · 12 comments · May be fixed by #145
Open

central issue for "default extensions" #166

ljharb opened this issue Jun 16, 2018 · 12 comments · May be fixed by #145

Comments

@ljharb
Copy link
Member

ljharb commented Jun 16, 2018

This issue encompasses anything that deals with "what the default extensions are/should be".

There's some PRs out that are hoping to change the defaults:

I'm opening this so I can close the other issues, and so any further discussion can happen here.

Please try to read all of the previous discussions before commenting.

@snuggs
Copy link

snuggs commented Jul 11, 2018

@ljharb well done! I'm subscribed and have my eyes peeled. Seems like as I predicted last year there will be more eyeballs looking in the require.extensions direction.

This is a great synopsis but even myself remember you had made a couple suggestions. I wonder what they are currently (especially with the new .mjs extension add we've been working on with IETF. This way I can see where I can help and take some concerns off your plate.

Thoughts?

@ljharb
Copy link
Member Author

ljharb commented Jul 11, 2018

As it relates to .mjs, resolve will absolutely add it to the default extension list the instant node ships it unflagged - but not before (that will also be when it's present in require.extensions in node).

@snuggs
Copy link

snuggs commented Jul 11, 2018

@ljharb sounds like a plan! Any ref we can use to stick in the description / comment to watchdog?

Seems like you know better than me. I've merely been judging off PTSD of the community and in the classrooms. :-|

FWIW I'm totally against .mjs and believe it creates some unnecessary social fractures within the ecosystem but that's just my opinion not the community at large's.

@ljharb
Copy link
Member Author

ljharb commented Jul 11, 2018

A file extension is strictly necessary, since Module and Script have distinct (and ambiguous) parsing goals, and a file extension is the proper and sole way to disambiguate textual parsing goals - so this result was inevitable once the choice of two parse goals was made in TC39 back in 2013 or so.

@snuggs

This comment has been minimized.

@ljharb

This comment has been minimized.

@snuggs

This comment has been minimized.

@ljharb

This comment has been minimized.

@snuggs

This comment has been minimized.

@ljharb

This comment has been minimized.

@snuggs

This comment has been minimized.

@ljharb

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants