Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommended changes resulting from automated audit #4

Open
4 tasks
Jericho opened this issue Jun 5, 2018 · 3 comments · May be fixed by #7
Open
4 tasks

Recommended changes resulting from automated audit #4

Jericho opened this issue Jun 5, 2018 · 3 comments · May be fixed by #7

Comments

@Jericho
Copy link

Jericho commented Jun 5, 2018 •
edited
Loading

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.21.1. Please upgrade to 0.28.0
  • You are currently referencing Cake.Common 0.21.1. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
  • Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.
@burakince
Copy link
Owner

Hi @Jericho

Thanks for your feedback. I will fix them as soon as possible.

Could you send me commands or steps for automated audit? Or any link about to this process?

Thanks,
Burak

@Jericho
Copy link
Author

Jericho commented Jun 5, 2018

There's no command for you the execute. The report is automatically updated twice daily at noon and midnight UTC: https://github.com/cake-contrib/Home/blob/master/Audit.md

@Jericho
Copy link
Author

Jericho commented Apr 20, 2019

We performed a follow up automated audit of your Cake addin and found that some (or all) issues previously identified have not been resolved.

We strongly encourage you to make the modifications previously highlighted.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This comment was created by a tool: Cake.AddinDiscoverer version 3.12.1

Jericho added a commit to Jericho/Cake.DependencyCheck that referenced this issue Apr 30, 2019
@Jericho
(burakinceGH-4) Fix TargetFrameworks
3c3f8a0
Jericho added a commit to Jericho/Cake.DependencyCheck that referenced this issue Apr 30, 2019
@Jericho
(burakinceGH-4) Upgrade Cake.Core reference to 0.33.0
93bbec8
Jericho added a commit to Jericho/Cake.DependencyCheck that referenced this issue Apr 30, 2019
@Jericho
(burakinceGH-4) Cake.Core reference should be private
2a56e09
Jericho added a commit to Jericho/Cake.DependencyCheck that referenced this issue Apr 30, 2019
@Jericho
(burakinceGH-4) Upgrade Cake.Common reference to 0.33.0
4b78631
Jericho added a commit to Jericho/Cake.DependencyCheck that referenced this issue Apr 30, 2019
@Jericho
(burakinceGH-4) Cake.Common reference should be private
a36a6bc
@Jericho Jericho linked a pull request Apr 30, 2019 that will close this issue
Open
Repository owner deleted a comment from Yucao-cy Feb 23, 2024
@github-staff github-staff deleted a comment from thangtq-pionero Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues identified by automated audit Jericho/Cake.DependencyCheck
2 participants
@Jericho @burakince