Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published Windows executables should end in exe and use a zip format #437

Open
jeffcharles opened this issue Jul 17, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@jeffcharles
Copy link
Collaborator

Operating system: Windows
Processor architecture: N/A
Rust version: N/A
Javy version: v1.1.2

Problem

At the moment, the build assets workflow creates a Windows executable but drops the required exe extension and uses gzip instead of zip for compressing the executable. The exe extension is required on Windows for all executable binaries and Windows does not have a built in way to decompress gzip files but does have a built in way to decompress zip files.

Error Message and Context

Technically someone could install gzip and manually rename the executable file to add the exe extension, but we should just produce executables in the correct format.

@jeffcharles jeffcharles added the bug Something isn't working label Jul 17, 2023
@jeffcharles
Copy link
Collaborator Author

It's worth noting that the javy-cli NPM package currently assumes there will be a .gz file available for Windows on the release and uses gunzip to decompress the response body from downloading that file. It's also worth noting that the presence of an .exe extension in the URL for the Windows asset will also break the NPM package's download logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant